Improve compatibility with other operating systems#274
Open
swissspidy wants to merge 131 commits intomainfrom
Open
Improve compatibility with other operating systems#274swissspidy wants to merge 131 commits intomainfrom
swissspidy wants to merge 131 commits intomainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
* Initial plan * Add cleanup for temporary files on Windows in background_proc Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com> * Use error suppression for unlink calls to handle edge cases Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com> * Use explicit file_exists checks before cleanup Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com> * Track and cleanup temporary files for all background processes Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com> * Refactor: Extract cleanup logic into helper method Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Local should take precedence, not global
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to improve Windows support a little bit so that tests could run on CI. Doing things in PHP vs. CLI commands is one step.
Lots of AI code changes in here, might need some cleanup
Main change is blocked by wp-cli/wp-cli#6124To-do:
See #155